Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(changePasswordForm): add id to change password button to surface externally [KHCP-6681] #989

Merged
merged 1 commit into from
Mar 31, 2023
Merged

fix(changePasswordForm): add id to change password button to surface externally [KHCP-6681] #989

merged 1 commit into from
Mar 31, 2023

Conversation

mptap
Copy link
Contributor

@mptap mptap commented Mar 30, 2023 •
edited
Loading

…

Summary

https://konghq.atlassian.net/browse/KHCP-6618

adds id to change password button to surface externally for ease of development

Ready-To-Review Checklist

  • Tests: Includes any new/updated component tests
  • Docs: updates documentation as needed
  • Commit format/atomicity: the commits follow the guidelines outlined here

Ready-To-Merge Checklist

  • Reviewer - At least one reviewer has reviewed the following:
    • Functional: reviewed acceptance criteria and functionally tested the changes
    • Tests: Reviewer has checked the automated tests for correctness and completeness

@mptap mptap requested a review from adamdehaven as a code owner March 30, 2023 22:23
@mptap mptap self-assigned this Mar 30, 2023
@mptap mptap force-pushed the fix/khcp-6681-change-password-button-id branch from 02600e3 to 9286e50 Compare March 30, 2023 22:25
@mptap mptap enabled auto-merge (squash) March 30, 2023 22:25
@mptap mptap requested review from aanchalm01 and a team March 30, 2023 22:29
@mptap mptap merged commit e86c1d4 into main Mar 31, 2023
@mptap mptap deleted the fix/khcp-6681-change-password-button-id branch March 31, 2023 01:08
kongponents-bot pushed a commit that referenced this pull request Mar 31, 2023
@semantic-release-bot
chore(release): 1.30.4 [skip ci]
14be4fc 
## [1.30.4](v1.30.3...v1.30.4) (2023-03-31)

### Bug Fixes

* **changePasswordForm:** add id to change password button to surface externally [KHCP-6681] ([#989](#989)) ([e86c1d4](e86c1d4))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 1.30.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdehaven adamdehaven adamdehaven approved these changes

@aanchalm01 aanchalm01 aanchalm01 approved these changes

Assignees

@mptap mptap

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mptap @kongponents-bot @adamdehaven @aanchalm01