fix(tracing/propagation): set parent span correctly #11468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
force-pushed
the
fix/tracing-parent-span-id
branch
from
453e49c
to
86ccd8d
Compare
1 task
samugi
force-pushed
the
fix/tracing-parent-span-id
branch
from
86ccd8d
to
cdec011
Compare
samugi
force-pushed
the
fix/tracing-parent-span-id
branch
from
cdec011
to
56cf427
Compare
vm-001
force-pushed
the
fix/tracing-parent-span-id
branch
from
56cf427
to
566f880
Compare
* fix an issue where the parent span was set incorrectly when the balancer instrumentation was disabled (the parent span was set to a temporary balancer span that was never reported)
samugi
force-pushed
the
fix/tracing-parent-span-id
branch
from
566f880
to
73602b6
Compare
3 tasks
Water-Melon
approved these changes
Aug 31, 2023
team-gateway-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
* fix an issue where the parent span was set incorrectly when the balancer instrumentation was disabled (the parent span was set to a temporary balancer span that was never reported) (cherry picked from commit a6659ed)
1 task
kikito
pushed a commit
that referenced
this pull request
Sep 25, 2023
* fix an issue where the parent span was set incorrectly when the balancer instrumentation was disabled (the parent span was set to a temporary balancer span that was never reported) (cherry picked from commit a6659ed)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.3.x release/3.3.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.3.x
# Create a new branch
git switch --create backport-11468-to-release/3.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a6659edb925ba07306eb2be212df06dbcc5f2a9f
# Push it to GitHub
git push --set-upstream origin backport-11468-to-release/3.3.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.3.xThen, create a pull request where the |
samugi
added a commit
that referenced
this pull request
Sep 25, 2023
* fix an issue where the parent span was set incorrectly when the balancer instrumentation was disabled (the parent span was set to a temporary balancer span that was never reported)
Closed
3 tasks
3 tasks
samugi
added a commit
that referenced
this pull request
Sep 25, 2023
* fix an issue where the parent span was set incorrectly when the balancer instrumentation was disabled (the parent span was set to a temporary balancer span that was never reported) (cherry picked from commit a6659ed) Co-authored-by: Samuele <samuele@konghq.com>
kikito
pushed a commit
that referenced
this pull request
Sep 26, 2023
* fix an issue where the parent span was set incorrectly when the balancer instrumentation was disabled (the parent span was set to a temporary balancer span that was never reported)
samugi
added a commit
that referenced
this pull request
Sep 27, 2023
* fix an issue where the parent span was set incorrectly when the balancer instrumentation was disabled (the parent span was set to a temporary balancer span that was never reported)
This was referenced Oct 24, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue where the parent span was set incorrectly when the balancer instrumentation was disabled (the parent span ID was set to a temporary balancer span that was never reported).
Checklist
There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREFull changelog
Issue reference
https://konghq.atlassian.net/browse/KAG-2281
closes #11294