feat(cors): Support private network access #11523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crossing-origin prelight request. A new parameter `private_network` is added to determined whether the `Access-Control-Allow-Private-Network` header should be carried in the response headers with `true` as the value.
liverpool8056
force-pushed
the
feat/cors-private-network-support
branch
from
a78e7fe to
c9ae4cb
Compare
ms2008
requested changes
Sep 8, 2023
There was a problem hiding this comment.
New fields need to be added to the removed fields to support mixed-version clusters. It is necessary to raise a PR to https://github.com/Kong/docs.konghq.com to introduce this feature as well.
ms2008
changed the title
ms2008
approved these changes
Sep 8, 2023
outsinre
reviewed
Sep 11, 2023
| @@ -35,11 +35,11 @@ end | |||
| local function get_plugin(node_id, node_version, name) | |||
| local res, err = cluster_client({ id = node_id, version = node_version }) | |||
| assert.is_nil(err) | |||
| assert.is_table(res and res.config and res.config.plugins, | |||
| assert.is_table(res and res.config_table and res.config_table.plugins, | |||
There was a problem hiding this comment.
This was referenced Sep 17, 2023
liverpool8056
added a commit
that referenced
this pull request
Feb 22, 2024
The Access-Control-Request-Private-Network header in crossing-origin pre-light requests is supported through adding a new parameter private_network which determines whether the Access-Control-Allow-Private-Network header should be carried in the response headers with true as the value. FTI-5258
ms2008
pushed a commit
that referenced
this pull request
Feb 26, 2024
…12599) * feat(cors): Support private network access (#11523) The Access-Control-Request-Private-Network header in crossing-origin pre-light requests is supported through adding a new parameter private_network which determines whether the Access-Control-Allow-Private-Network header should be carried in the response headers with true as the value. * change version number in removed_fileds and spce for compatibility FTI-5258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
Access-Control-Request-Private-Networkheader in crossing-origin pre-light requests is supported through adding a new parameterprivate_networkwhich determines whether theAccess-Control-Allow-Private-Networkheader should be carried in the response headers withtrueas the value.Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.mdFull changelog
Issue reference
FTI-5258