fix(opentelemetry): fix a bug that will cause a failure of sending tracing data to datadog agent #11599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
author/community
tracing data to datadog agent when the value of `x-datadog-parent-id` header from downstream is a short dec string. In this PR, a formatter is added for ensuring the field of `parent-span-id` meet specification of the otel protocol. FTI-5375
liverpool8056
force-pushed
the
fix-opentelemetry-datadog-spanid
branch
from
57cbde0
to
54be856
Compare
catbro666
approved these changes
Sep 20, 2023
samugi
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix a bug that will cause a failure of sending tracing data to datadog agent when the value of
x-datadog-parent-idheader from downstream is a short dec string.In this PR, a formatter is added for ensuring the field of
parent-span-idmeet specification of the otel protocol.Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.mdFull changelog
Issue reference
FTI-5375