Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add lmdb validation tag directive #12026

Merged
merged 30 commits into from
Nov 29, 2023
Merged

feat(core): add lmdb validation tag directive #12026

merged 30 commits into from
Nov 29, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Nov 15, 2023 •
edited
Loading

Summary

Bump lua-resty-lmdb to 1.4.1 , and introduce the new directive lmdb_validation_tag.

See: https://github.com/Kong/lua-resty-lmdb/releases/tag/v1.4.1

KAG-3093

Checklist

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@chronolaw
Copy link
Contributor Author

It seems that lmdb_validation_tag causes many test failing, I am still working on it.

@chronolaw chronolaw mentioned this pull request Nov 16, 2023
Merged
3 tasks
@chronolaw chronolaw mentioned this pull request Nov 22, 2023
Merged
@chronolaw chronolaw marked this pull request as ready for review November 23, 2023 02:09
dndx
dndx requested changes Nov 24, 2023
View reviewed changes
kong/conf_loader/init.lua Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 25, 2023
dndx
dndx requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@dndx dndx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases should be added to:

https://github.com/Kong/kong/blob/master/spec/01-unit/03-conf_loader_spec.lua
https://github.com/Kong/kong/blob/master/spec/01-unit/04-prefix_handler_spec.lua

changelog/unreleased/kong/introduce_lmdb_validation_tag.yml Outdated Show resolved Hide resolved
dndx
dndx requested changes Nov 27, 2023
View reviewed changes
spec/01-unit/03-conf_loader_spec.lua Outdated Show resolved Hide resolved
@dndx dndx merged commit 6d44e81 into master Nov 29, 2023
24 checks passed
@dndx dndx deleted the feat/add_lmdb_validation_tag branch November 29, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dndx dndx dndx approved these changes

@chobits chobits chobits approved these changes

Assignees
No one assigned
Labels
core/configuration core/templates size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chronolaw @chobits @dndx