feat(log-serializer): add source property to log-serializer

[vm-001]

Summary:

Add a new property source to indicate the response is generated by kong or upstream.

FTI-5522

[oowl]

Most LGTM, But I want to clarify that not all the response code errors can be captured by Kong Lua code, Like 400 or Nginx internal error. it can not be captured in our implementation of get_source PDK.

[vm-001]

@oowl Are you referring to the internal EE PR? Because this PR only adds one propertysource, the response.upstream_status was done by another PR a long time ago. See #10296

The source value comes from kong.response.get_source, which has a default value error, and will be transformed to kong.

[gszr]

very minor comments; otherwise, LGTM

[tzssangglass]

so okong.response.get_source(ongx.ctx) only have 3 values , exit, error or service?

[vm-001]

correct.

kong/kong/pdk/response.lua

Lines 345 to 364 in 6077171

	function _RESPONSE.get_source(ctx)
	if ctx == nil then
	check_phase(header_body_log)
	ctx = ngx.ctx
	end
	if ctx.KONG_UNEXPECTED then
	return "error"
	end
	if ctx.KONG_EXITED then
	return "exit"
	end
	if ctx.KONG_PROXIED then
	return "service"
	end
	return "error"
	end

[tzssangglass]

I prefer to use a constant table to contain these three values to prevent if someone change function _RESPONSE.get_source(ctx) but forget to update it here.

[gszr]

@vm-001 any thoughts?

[vm-001]

I don't have any strong opinions on this. Just feel replacing the if conditions with a constant table may be not completed. The vars defined in _RESPONSE.get_source function should also be changed. Please ref the latest commit to get what I'm saying.

[gszr]

I understand @vm-001's point and agree this would be an improvement; in the interest of keeping things moving, let's merge this as-is, and, if you both think this is a desirable improvement, please create a JIRA to track it.

[vm-001]

Thank you @gszr. @tzssangglass Checkout the latest commit to see if it addresses your concern. If yes. please resolve this comment. Otherwise, open a ticket then we can track it.

[team-gateway-bot]

Successfully created cherry-pick PR for master:

• https://github.com/kong/kong-ee/pull/7942