Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: display a warning message when Kong Manager is enabled but the Admin API is not enabled #12071

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

nekolab
Copy link
Contributor

@nekolab nekolab commented Nov 21, 2023

Feedback from issue #11995 highlighted potential user confusion due to the internal connection between Kong Manager and the Admin API.

To address this, a warning message will be displayed to notify users that the current configuration combination will not function as expected.

This resolves KAG-3158

Summary

Checklist

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@nekolab nekolab force-pushed the chore/km-admin-disabled-warning branch from 1a62c6e to fca2a0c Compare November 21, 2023 08:10
@nekolab nekolab marked this pull request as ready for review November 21, 2023 08:35
… Admin API is not enabled

Feedback from issue #11995 highlighted potential user confusion
due to the internal connection between Kong Manager and the Admin API.

To address this, a warning message will now be displayed to notify users
that the current configuration combination will not function as expected.

This resolves KAG-3158
@nekolab nekolab force-pushed the chore/km-admin-disabled-warning branch from fca2a0c to 005a993 Compare November 27, 2023 06:27
@windmgc windmgc merged commit f920f1f into master Nov 27, 2023
27 checks passed
@windmgc windmgc deleted the chore/km-admin-disabled-warning branch November 27, 2023 07:09
@jschmid1 jschmid1 added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jan 25, 2024
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12071-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12071-to-master-to-upstream
git checkout -b cherry-pick-12071-to-master-to-upstream
ancref=$(git merge-base 53d50e740badb59caa67ee002edfddb8396fbc24 005a9932645faa87b0dd39a4fc8f5e1961f7dd23)
git cherry-pick -x $ancref..005a9932645faa87b0dd39a4fc8f5e1961f7dd23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/configuration size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants