Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): bump dns_stale_ttl default to 1 hour #12087

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Conversation

chobits
Copy link
Contributor

@chobits chobits commented Nov 23, 2023

Summary

A longer stale TTL can help ease the load on these slower DNS servers, reducing proxy latency and making the product more adaptable to their speed.

Checklist

Full changelog

  • bump dns_stale_ttl default to 1 day

Issue reference

Fix KAG-3080

kong.conf.default Outdated Show resolved Hide resolved
@dndx dndx added pr/do not merge pr/discussion This PR is being debated. Probably just a few details. labels Nov 28, 2023
@dndx
Copy link
Member

dndx commented Nov 28, 2023

Hold off merging for now until @hbagdi agrees with the TTL value.

@chobits chobits changed the title feat(templates): bump dns_stale_ttl default to 1 day feat(templates): bump dns_stale_ttl default to 1 hour Nov 29, 2023
chobits and others added 4 commits December 5, 2023 10:21
A longer stale TTL can help ease the load on these slower DNS servers,
reducing  proxy latency and making the product more adaptable to their speed.

KAG-3080
Co-authored-by: Datong Sun <datong.sun@konghq.com>
dndx and others added 2 commits December 5, 2023 13:58
team-gateway-bot pushed a commit that referenced this pull request Dec 5, 2023
A longer stale TTL can help reduce the load on less performant/reliable DNS servers,
reducing proxy latency and availability impact to Kong's proxy path.

KAG-3080

Co-authored-by: Datong Sun <datong.sun@konghq.com>

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
(cherry picked from commit 533d3f7)
@chobits chobits added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Dec 5, 2023
dndx pushed a commit that referenced this pull request Dec 6, 2023
A longer stale TTL can help reduce the load on less performant/reliable DNS servers,
reducing proxy latency and availability impact to Kong's proxy path.

KAG-3080

Co-authored-by: Datong Sun <datong.sun@konghq.com>

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
(cherry picked from commit 533d3f7)
dndx pushed a commit that referenced this pull request Dec 6, 2023
A longer stale TTL can help reduce the load on less performant/reliable DNS servers,
reducing proxy latency and availability impact to Kong's proxy path.

KAG-3080

Co-authored-by: Datong Sun <datong.sun@konghq.com>

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
(cherry picked from commit 533d3f7)
@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/2.8.x with exitcode 1

@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/2.8.x with exitcode 1

@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/3.2.x:

github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
A longer stale TTL can help reduce the load on less performant/reliable DNS servers,
reducing proxy latency and availability impact to Kong's proxy path.

KAG-3080

Co-authored-by: Datong Sun <datong.sun@konghq.com>

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
(cherry picked from commit 533d3f7)
@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.2.x with exitcode 1

@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.3.x with exitcode 1

@team-gateway-bot
Copy link
Collaborator

'git push --set-upstream upstream cherry-pick-12087-to-master-to-upstream' failed with exit code 1

github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
A longer stale TTL can help reduce the load on less performant/reliable DNS servers,
reducing proxy latency and availability impact to Kong's proxy path.

KAG-3080

Co-authored-by: Datong Sun <datong.sun@konghq.com>

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
(cherry picked from commit 533d3f7)
@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.4.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.4.x
git worktree add -d .worktree/backport-12087-to-release/3.4.x origin/release/3.4.x
cd .worktree/backport-12087-to-release/3.4.x
git switch --create backport-12087-to-release/3.4.x
git cherry-pick -x 533d3f76177596dcb9b5911dec52eb2cfff9fdf7

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.5.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.5.x
git worktree add -d .worktree/backport-12087-to-release/3.5.x origin/release/3.5.x
cd .worktree/backport-12087-to-release/3.5.x
git switch --create backport-12087-to-release/3.5.x
git cherry-pick -x 533d3f76177596dcb9b5911dec52eb2cfff9fdf7

@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/3.3.x:

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.4.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.4.x
git worktree add -d .worktree/backport-12087-to-release/3.4.x origin/release/3.4.x
cd .worktree/backport-12087-to-release/3.4.x
git switch --create backport-12087-to-release/3.4.x
git cherry-pick -x 533d3f76177596dcb9b5911dec52eb2cfff9fdf7

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.5.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.5.x
git worktree add -d .worktree/backport-12087-to-release/3.5.x origin/release/3.5.x
cd .worktree/backport-12087-to-release/3.5.x
git switch --create backport-12087-to-release/3.5.x
git cherry-pick -x 533d3f76177596dcb9b5911dec52eb2cfff9fdf7

windmgc pushed a commit that referenced this pull request Dec 11, 2023
A longer stale TTL can help reduce the load on less performant/reliable DNS servers,
reducing proxy latency and availability impact to Kong's proxy path.

KAG-3080

Co-authored-by: Datong Sun <datong.sun@konghq.com>

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
(cherry picked from commit 533d3f7)
windmgc pushed a commit that referenced this pull request Dec 11, 2023
A longer stale TTL can help reduce the load on less performant/reliable DNS servers,
reducing proxy latency and availability impact to Kong's proxy path.

KAG-3080

Co-authored-by: Datong Sun <datong.sun@konghq.com>

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
(cherry picked from commit 533d3f7)
windmgc pushed a commit that referenced this pull request Dec 11, 2023
A longer stale TTL can help reduce the load on less performant/reliable DNS servers,
reducing proxy latency and availability impact to Kong's proxy path.

KAG-3080

Co-authored-by: Datong Sun <datong.sun@konghq.com>

---------

Co-authored-by: Datong Sun <datong.sun@konghq.com>
(cherry picked from commit 533d3f7)
AndyZhang0707 added a commit that referenced this pull request Jul 18, 2024
AndyZhang0707 added a commit that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/templates pr/discussion This PR is being debated. Probably just a few details. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants