perf(opentelemetry): increase queue max batch size #12488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The max batch size for Opentelemetry was set to the default value: 1 the value actually refers to the number of spans in a batch, so we are increasing the default value to 200 which corresponds to what the default value used to be with the "old" queue implementation.
samugi
force-pushed
the
chore/otel-queue-max-batch-size
branch
from
0df0e06
to
5d3c48e
Compare
samugi
added
the
cherry-pick kong-ee
hanshuebner
approved these changes
Feb 1, 2024
bungle
approved these changes
Feb 1, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/3.3.x
git worktree add -d .worktree/backport-12488-to-release/3.3.x origin/release/3.3.x
cd .worktree/backport-12488-to-release/3.3.x
git switch --create backport-12488-to-release/3.3.x
git cherry-pick -x c7cb900f4919e6b320b7bdf9132cfa4747679760 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
The max batch size for Opentelemetry was set to the default value: 1 the value actually refers to the number of spans in a batch, so we are increasing the default value to 200 which corresponds to what the default value used to be with the "old" queue implementation. (cherry picked from commit c7cb900)
3 tasks
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
The max batch size for Opentelemetry was set to the default value: 1 the value actually refers to the number of spans in a batch, so we are increasing the default value to 200 which corresponds to what the default value used to be with the "old" queue implementation. (cherry picked from commit c7cb900)
3 tasks
|
Successfully created backport PR for |
bungle
pushed a commit
that referenced
this pull request
Feb 1, 2024
The max batch size for Opentelemetry was set to the default value: 1 the value actually refers to the number of spans in a batch, so we are increasing the default value to 200 which corresponds to what the default value used to be with the "old" queue implementation. (cherry picked from commit c7cb900)
samugi
added a commit
that referenced
this pull request
Feb 2, 2024
The max batch size for Opentelemetry was set to the default value: 1 the value actually refers to the number of spans in a batch, so we are increasing the default value to 200 which corresponds to what the default value used to be with the "old" queue implementation. (cherry picked from commit c7cb900)
samugi
added a commit
that referenced
this pull request
Feb 2, 2024
The max batch size for Opentelemetry was set to the default value: 1 the value actually refers to the number of spans in a batch, so we are increasing the default value to 200 which corresponds to what the default value used to be with the "old" queue implementation.
This was referenced Feb 2, 2024
hanshuebner
pushed a commit
that referenced
this pull request
Feb 5, 2024
The max batch size for Opentelemetry was set to the default value: 1 the value actually refers to the number of spans in a batch, so we are increasing the default value to 200 which corresponds to what the default value used to be with the "old" queue implementation.
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/3.3.x
git worktree add -d .worktree/backport-12488-to-release/3.3.x origin/release/3.3.x
cd .worktree/backport-12488-to-release/3.3.x
git switch --create backport-12488-to-release/3.3.x
git cherry-pick -x c7cb900f4919e6b320b7bdf9132cfa4747679760 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/3.4.x
git worktree add -d .worktree/backport-12488-to-release/3.4.x origin/release/3.4.x
cd .worktree/backport-12488-to-release/3.4.x
git switch --create backport-12488-to-release/3.4.x
git cherry-pick -x c7cb900f4919e6b320b7bdf9132cfa4747679760 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/3.5.x
git worktree add -d .worktree/backport-12488-to-release/3.5.x origin/release/3.5.x
cd .worktree/backport-12488-to-release/3.5.x
git switch --create backport-12488-to-release/3.5.x
git cherry-pick -x c7cb900f4919e6b320b7bdf9132cfa4747679760 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
The max batch size for Opentelemetry was set to the default value: 1 the value actually refers to the number of spans in a batch, so we are increasing the default value to 200 which corresponds to what the default value used to be with the "old" queue implementation. (cherry picked from commit c7cb900)
3 tasks
|
Successfully created cherry-pick PR for |
|
Successfully created backport PR for |
This was referenced Feb 13, 2024
[backport -> release/3.3.x] fix(opentelemetry): migration - increase default queue batch size
#12558
Merged
[backport -> release/3.4.x] fix(opentelemetry): migration - increase default queue batch size
#12559
Merged
[backport -> release/3.5.x] fix(opentelemetry): migration - increase default queue batch size
#12560
Merged
bungle
pushed a commit
that referenced
this pull request
Feb 13, 2024
The max batch size for Opentelemetry was set to the default value: 1 the value actually refers to the number of spans in a batch, so we are increasing the default value to 200 which corresponds to what the default value used to be with the "old" queue implementation. (cherry picked from commit c7cb900)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The max batch size for Opentelemetry was set to the default value: 1 the value actually refers to the number of spans in a batch, so we are increasing the default value to 200 which corresponds to what the default value used to be with the "old" queue implementation.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
https://konghq.atlassian.net/browse/KAG-3173