Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jwt): add support for ES512, PS256, PS384, PS512 #12638

Merged
merged 2 commits into from
Mar 8, 2024
Merged

feat(jwt): add support for ES512, PS256, PS384, PS512 #12638

merged 2 commits into from
Mar 8, 2024

Conversation

jschmid1
Copy link
Contributor

@jschmid1 jschmid1 commented Feb 26, 2024 •
edited
Loading

Summary

Added support for ES512, PS256, PS384, PS512 algorithms for the JWT plugin.

Checklist

Issue reference

Fix https://konghq.atlassian.net/browse/KAG-3821

@jschmid1 jschmid1 added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Feb 26, 2024
@jschmid1 jschmid1 marked this pull request as ready for review February 28, 2024 10:02
@jschmid1 jschmid1 changed the title feat(jwt): add support for ES512 feat(jwt): add support for ES512, PS256, PS384, PS512 Feb 28, 2024
samugi
samugi reviewed Feb 29, 2024
View reviewed changes
Copy link
Member

@samugi samugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left 2 comments

kong/plugins/jwt/jwt_parser.lua Show resolved Hide resolved
spec/03-plugins/16-jwt/03-access_spec.lua Outdated Show resolved Hide resolved
@jschmid1
feat(jwt): add support for ES512
b0dacc8 
Signed-off-by: Joshua Schmid <jaiks@posteo.de>
@jschmid1
feat(jwt): add support for PS256, PS384 and PS512
1642246 
Signed-off-by: Joshua Schmid <jaiks@posteo.de>
samugi
samugi approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@samugi samugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jschmid1 jschmid1 requested a review from StarlightIbuki March 6, 2024 14:45
@jschmid1 jschmid1 merged commit b57e553 into master Mar 8, 2024
26 checks passed
@jschmid1 jschmid1 deleted the feat/jwt-es512 branch March 8, 2024 08:33
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samugi samugi samugi approved these changes

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

Assignees

@jschmid1 jschmid1

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/jwt schema-change-noteworthy size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jschmid1 @team-gateway-bot @samugi @StarlightIbuki