chore(tracing): do not error on too short trace id + tests #12848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/pdk
core/tracing
cherry-pick kong-ee
samugi
force-pushed
the
chore/sampling-short-trace-ids-fw-port
branch
3 times, most recently
from
205bdfe to
68bdbf9
Compare
dndx
approved these changes
Apr 11, 2024
|
@samugi Should there be a changelog for this PDK related change? It should be a |
ADD-SP
approved these changes
Apr 11, 2024
samugi
force-pushed
the
chore/sampling-short-trace-ids-fw-port
branch
from
68bdbf9 to
e8ba511
Compare
samugi
force-pushed
the
chore/sampling-short-trace-ids-fw-port
branch
from
e8ba511 to
3699f0d
Compare
This is a forward port of Kong/kong-ee#8767 the actual fix is not needed because already covered by the new propagation module. This commit ports the updates to the pdk (no longer throw error on too short id) and tests.
samugi
force-pushed
the
chore/sampling-short-trace-ids-fw-port
branch
from
3699f0d to
718351f
Compare
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a forward port of
kong-ee/pull/8767the actual fix is not needed because already covered by the new propagation module.This commit ports the updates to the pdk (no longer throw error on too short id) and tests.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4218