fix(vault): vault secret without TTL configuration should not be refreshed #12877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/pdk
cherry-pick kong-ee
jschmid1
requested changes
Apr 18, 2024
changelog/unreleased/kong/fix-vault-secret-update-without-ttl.yml
Outdated
Show resolved
Hide resolved
windmgc
force-pushed
the
prevent-vault-reference-refresh-when-no-ttl-configured
branch
from
4796861
to
82dbedb
Compare
jschmid1
approved these changes
Apr 23, 2024
jschmid1
deleted the
prevent-vault-reference-refresh-when-no-ttl-configured
branch
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug that a vault secret could be refreshed by rotation timer after a rotation interval, even if it has no TTL configuration(which means the secret will expire after DAO_MAX_TTL instead of a rotation interval)
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
FTI-5906
FTI-5916