Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport -> release/3.7.x] chore(ai-prompt-decorator): improve error handling and cleanup #12991

Merged
merged 1 commit into from
May 7, 2024
Merged

[backport -> release/3.7.x] chore(ai-prompt-decorator): improve error handling and cleanup #12991

merged 1 commit into from
May 7, 2024

Conversation

team-gateway-bot
Copy link
Collaborator

Automated backport to release/3.7.x, triggered by a label in #12907.

Original description

Summary

Checklist

Issues

Note to reviewers

  • in the github GUI disable the whitespace changes, since there is a lot of indentation changes
  • the schema changes are non-breaking afaict:
    • The default for required is already false, just more explicit now
    • Removing the default = {} is non-breaking since the entire object itself was not marked as required (and hence a user could have specified null in the past).

@Tieske @github-actions
chore(ai-prompt-decorator): improve error handling and cleanup (#12907)
ef86e82 
* chore(ai-prompt-decorator): improve error handling and cleanup

* chore(test): standard test filenames

* chore(ai-prompt-guard): improve error handling and cleanup

(cherry picked from commit b1b5ac9)
@team-gateway-bot team-gateway-bot added this to the 3.7.0 milestone May 7, 2024
@team-gateway-bot team-gateway-bot mentioned this pull request May 7, 2024
Merged
3 tasks
@locao locao merged commit 0349b1a into release/3.7.x May 7, 2024
52 checks passed
@locao locao deleted the backport-12907-to-release/3.7.x branch May 7, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locao locao locao approved these changes

@kikito kikito kikito approved these changes

@mikefero mikefero Awaiting requested review from mikefero

Assignees

@Tieske Tieske

@team-gateway-bot team-gateway-bot

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/ai-prompt-decorator plugins/ai-prompt-guard schema-change-noteworthy size/XXL
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@team-gateway-bot @kikito @locao @Tieske