fix(prometheus): improve logging when having the inconsistent labels count #13020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s count Currently, the prometheus plugin will log the following error if we have encountered the inconsisent label count while debugging: ``` [error]... inconsistent labels count, expected 6, got 5 ``` It's hard to identify which metric is going wrong, and it will be helpful if we can bring the metric name as well: ``` [error]... metric 'bandwidth_bytes' has the inconsistent labels count, expected 6, got 5 ```
github-actions
bot
added
plugins/prometheus
cherry-pick kong-ee
team-eng-enablement
added
the
author/community
|
@oowl Would you mind taking a look at this PR? |
|
https://github.com/Kong/kong/actions/runs/9072858739/job/24943120249?pr=13020#step:20:2126 The CI failure is not related to this PR. |
|
@chronolaw @StarlightIbuki could you help to take a look at this PR? |
StarlightIbuki
approved these changes
May 17, 2024
|
@chronolaw @oowl @StarlightIbuki, is this PR good to merge? |
|
@ADD-SP Would you mind having a look at this PR? |
ADD-SP
changed the title
ADD-SP
reviewed
Jun 3, 2024
Co-authored-by: Qi <call_far@outlook.com>
ADD-SP
approved these changes
Jun 4, 2024
ADD-SP
changed the title
|
@git-hulk Thanks for your contribution! |
|
Successfully created cherry-pick PR for |
|
@ADD-SP Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the Prometheus plugin will log the following error if we have encountered an inconsistent label count while debugging:
It's hard to identify which metric is going wrong, and it will be helpful if we can bring the metric name as well:
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.md