Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(LuaJIT): revert optimization for hash #13240

Merged
merged 2 commits into from
Jun 20, 2024
Merged

perf(LuaJIT): revert optimization for hash #13240

merged 2 commits into from
Jun 20, 2024

Conversation

kikito
Copy link
Member

@kikito kikito commented Jun 20, 2024 •
edited
Loading

Summary

This change reverts some hash optimizations in LuaJIT

Issue reference

Fix KAG-4646

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jun 20, 2024
@kikito kikito added backport release/3.7.x and removed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jun 20, 2024
@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jun 20, 2024
@kikito kikito changed the title chore(patches): revert optimization for hash. perf(LuaJIT): revert optimization for hash Jun 20, 2024
@zhongweiy zhongweiy self-requested a review June 20, 2024 16:02
dndx
dndx approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@dndx dndx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits together when merging. Thank you.

@kikito kikito merged commit 61df625 into master Jun 20, 2024
26 checks passed
@kikito kikito deleted the fix_hash branch June 20, 2024 16:05
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
@kikito @github-actions
perf(LuaJIT): revert optimization for hash (#13240)
95e6ef3 
* perf(luajit): revert optimization for hash

* docs(changelog): add changelog entry

---------

Co-authored-by: Zhongwei Yao <zhongwei.yao@konghq.com>
(cherry picked from commit 61df625)
@team-gateway-bot team-gateway-bot mentioned this pull request Jun 20, 2024
Merged
@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/3.7.x:

@kikito kikito removed the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jun 20, 2024
@Kong Kong deleted a comment from team-gateway-bot Jun 20, 2024
kikito added a commit that referenced this pull request Jun 20, 2024
@kikito
perf(LuaJIT): revert optimization for hash (#13240)
a9b7647 
* perf(luajit): revert optimization for hash

* docs(changelog): add changelog entry

---------

Co-authored-by: Zhongwei Yao <zhongwei.yao@konghq.com>
(cherry picked from commit 61df625)
kikito added a commit that referenced this pull request Jun 20, 2024
@kikito
perf(LuaJIT): revert optimization for hash (#13240)
9d5dcd9 
* perf(luajit): revert optimization for hash

* docs(changelog): add changelog entry

---------

Co-authored-by: Zhongwei Yao <zhongwei.yao@konghq.com>
(cherry picked from commit 61df625)
kikito added a commit that referenced this pull request Jun 20, 2024
@kikito
perf(LuaJIT): revert optimization for hash (#13240)
e99eb0f 
* perf(luajit): revert optimization for hash

* docs(changelog): add changelog entry

---------

Co-authored-by: Zhongwei Yao <zhongwei.yao@konghq.com>
(cherry picked from commit 61df625)
@kikito kikito mentioned this pull request Jun 20, 2024
Closed
github-actions bot pushed a commit that referenced this pull request Jun 21, 2024
@kikito @github-actions
perf(LuaJIT): revert optimization for hash (#13240)
8b8121a 
* perf(luajit): revert optimization for hash

* docs(changelog): add changelog entry

---------

Co-authored-by: Zhongwei Yao <zhongwei.yao@konghq.com>
(cherry picked from commit 61df625)
@team-gateway-bot team-gateway-bot mentioned this pull request Jun 21, 2024
Merged
@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/2.8.x:

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.7.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.7.x
git worktree add -d .worktree/backport-13240-to-release/3.7.x origin/release/3.7.x
cd .worktree/backport-13240-to-release/3.7.x
git switch --create backport-13240-to-release/3.7.x
git cherry-pick -x 61df625c851b56aa34ac64f6051a9e6fd02bcec4

AndyZhang0707 pushed a commit that referenced this pull request Jun 21, 2024
@kikito @AndyZhang0707
perf(LuaJIT): revert optimization for hash (#13240)
0628d40 
* perf(luajit): revert optimization for hash

* docs(changelog): add changelog entry

---------

Co-authored-by: Zhongwei Yao <zhongwei.yao@konghq.com>
(cherry picked from commit 61df625)
AndyZhang0707 pushed a commit that referenced this pull request Jun 21, 2024
@kikito @AndyZhang0707
perf(LuaJIT): revert optimization for hash (#13240)
e225515 
* perf(luajit): revert optimization for hash

* docs(changelog): add changelog entry

---------

Co-authored-by: Zhongwei Yao <zhongwei.yao@konghq.com>
(cherry picked from commit 61df625)
This was referenced Jun 21, 2024
Closed
Merged
AndyZhang0707 pushed a commit that referenced this pull request Jun 21, 2024
@kikito @AndyZhang0707
perf(LuaJIT): revert optimization for hash (#13240)
563ff39 
* perf(luajit): revert optimization for hash

* docs(changelog): add changelog entry

---------

Co-authored-by: Zhongwei Yao <zhongwei.yao@konghq.com>
(cherry picked from commit 61df625)
AndyZhang0707 pushed a commit that referenced this pull request Jun 21, 2024
@kikito @AndyZhang0707
perf(LuaJIT): revert optimization for hash (#13240)
a50bbeb 
* perf(luajit): revert optimization for hash

* docs(changelog): add changelog entry

---------

Co-authored-by: Zhongwei Yao <zhongwei.yao@konghq.com>
(cherry picked from commit 61df625)
AndyZhang0707 pushed a commit that referenced this pull request Jun 21, 2024
@kikito @AndyZhang0707
perf(LuaJIT): revert optimization for hash (#13240)
1599608 
* perf(luajit): revert optimization for hash

* docs(changelog): add changelog entry

---------

Co-authored-by: Zhongwei Yao <zhongwei.yao@konghq.com>
(cherry picked from commit 61df625)
AndyZhang0707 pushed a commit that referenced this pull request Jun 21, 2024
@kikito @AndyZhang0707
perf(LuaJIT): revert optimization for hash (#13240)
8d52b91 
* perf(luajit): revert optimization for hash

* docs(changelog): add changelog entry

---------

Co-authored-by: Zhongwei Yao <zhongwei.yao@konghq.com>
(cherry picked from commit 61df625)
@AndyZhang0707 AndyZhang0707 mentioned this pull request Aug 21, 2024
Merged
3 tasks
@team-gateway-bot team-gateway-bot mentioned this pull request Aug 21, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongweiy zhongweiy zhongweiy approved these changes

@dndx dndx dndx approved these changes

Assignees

@kikito kikito

Labels
backport release/3.7.x build/bazel size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kikito @team-gateway-bot @dndx @zhongweiy @AndyZhang0707