fix(core): fix lua-nginx-module context was cleared when ngx.send_header() trigger filter_finalize case #13316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build/bazel
cherry-pick kong-ee
chronolaw
reviewed
Jul 1, 2024
changelog/unreleased/kong/fix-filter-finalize-in-send-header-clear-context.yml
Outdated
Show resolved
Hide resolved
chronolaw
reviewed
Jul 1, 2024
changelog/unreleased/kong/fix-filter-finalize-in-send-header-clear-context.yml
Outdated
Show resolved
Hide resolved
chronolaw
reviewed
Jul 1, 2024
build/openresty/patches/nginx-1.25.3_07-fix-lua-context-clean-by-send-header.patch
Show resolved
Hide resolved
chronolaw
changed the title
chronolaw
reviewed
Jul 1, 2024
changelog/unreleased/kong/fix-filter-finalize-in-send-header-clear-context.yml
Outdated
Show resolved
Hide resolved
windmgc
approved these changes
Jul 1, 2024
changelog/unreleased/kong/fix-filter-finalize-in-send-header-clear-context.yml
Outdated
Show resolved
Hide resolved
oowl
force-pushed
the
fix/filter_finalize_in_send_header
branch
from
5b7a4b8
to
79e3dd8
Compare
kikito
force-pushed
the
fix/filter_finalize_in_send_header
branch
from
b135a36
to
0eaebd1
Compare
chronolaw
approved these changes
Jul 9, 2024
|
hold on, I need to fix a test case conflict issue, So please do not do any rebase until I fix all the CI. |
oowl
force-pushed
the
fix/filter_finalize_in_send_header
branch
from
0eaebd1
to
1cd4be2
Compare
outsinre
approved these changes
Jul 12, 2024
changelog/unreleased/kong/fix-filter-finalize-in-send-header-clear-context.yml
Outdated
Show resolved
Hide resolved
oowl
force-pushed
the
fix/filter_finalize_in_send_header
branch
4 times, most recently
from
3cceca5
to
7c19e16
Compare
…r() trigger filter_finalize case
…lear-context.yml Co-authored-by: Keery Nie <windmgc@gmail.com>
oowl
force-pushed
the
fix/filter_finalize_in_send_header
branch
from
7c19e16
to
0c69a83
Compare
chronolaw
approved these changes
Jul 15, 2024
outsinre
approved these changes
Jul 15, 2024
|
Successfully created cherry-pick PR for |
oowl
added a commit
that referenced
this pull request
Aug 15, 2024
…der() trigger filter_finalize case (#13316) backport patch in openresty/lua-nginx-module#2323 Context: openresty/lua-nginx-module#2320 FTI-6005 (cherry picked from commit fb63631)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
backport patch in openresty/lua-nginx-module#2323
Context: openresty/lua-nginx-module#2320
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
FTI-6005