Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pdk): telemetry log #13329

Merged
merged 1 commit into from
Jul 9, 2024
Merged

feat(pdk): telemetry log #13329

merged 1 commit into from
Jul 9, 2024

Conversation

samugi
Copy link
Member

@samugi samugi commented Jul 3, 2024 •
edited
Loading

Summary

This PR:

  • introduces the kong.telemetry pdk module
  • adds the kong.telemetry.log function to allow generating log entries meant to be reported via the OpenTelemetry plugin

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • (no - docs are autogenerated) There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-4848

@samugi samugi marked this pull request as draft July 3, 2024 16:10
@github-actions github-actions bot added core/pdk core/logs cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jul 3, 2024
@samugi samugi mentioned this pull request Jul 4, 2024
Merged
4 tasks
@samugi samugi force-pushed the feat/otel-formatted-logs branch 5 times, most recently from a06b405 to c1f99a9 Compare July 5, 2024 09:23
Base automatically changed from feat/otel-formatted-logs to master July 5, 2024 09:55
@samugi samugi marked this pull request as ready for review July 5, 2024 11:46
@samugi samugi added this to the 3.8.0 milestone Jul 5, 2024
@samugi
feat(pdk): telemetry log
92c5b22 
This commit:
* introduces the `kong.telemetry` pdk module
* adds the `kong.telemetry.log` function to allow generating log entries
  meant to be reported via the OpenTelemetry plugin
hanshuebner
hanshuebner suggested changes Jul 8, 2024
View reviewed changes
kong/pdk/telemetry.lua Show resolved Hide resolved
Water-Melon
Water-Melon approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@Water-Melon Water-Melon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samugi samugi merged commit f957487 into master Jul 9, 2024
25 checks passed
@samugi samugi deleted the feat/pdk-telemetry-logs branch July 9, 2024 11:23
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Water-Melon Water-Melon Water-Melon approved these changes

@hanshuebner hanshuebner hanshuebner approved these changes

Assignees

@samugi samugi

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/logs core/pdk size/L
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@samugi @team-gateway-bot @hanshuebner @Water-Melon