fix(pdk.log): fix a bug that pdk.log.serialize() does not properly handle JSON nulls #13376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when json entity set via pdk.log.set_serialize_value contains cjson.null as value. FTI-6096
github-actions
bot
added
core/logs
cherry-pick kong-ee
liverpool8056
changed the title
liverpool8056
force-pushed
the
pdk-log-error
branch
from
b56d3d3 to
8ea095b
Compare
outsinre
approved these changes
Jul 15, 2024
catbro666
approved these changes
Jul 15, 2024
Co-authored-by: Zachary Hu <6426329+outsinre@users.noreply.github.com>
vm-001
reviewed
Jul 15, 2024
vm-001
reviewed
Jul 15, 2024
| it("does not fail when coming across 'cjson.null' in response body", function() | ||
| local cjson_null = require "cjson".null | ||
| kong.log.set_serialize_value("response.body", cjson_null) | ||
| local pok, value = pcall(kong.log.serialize, {}) |
There was a problem hiding this comment.
Not sure why it need be wrap by a pcall
There was a problem hiding this comment.
Just have a change to handle exception thrown from the serialize()
vm-001
reviewed
Jul 15, 2024
|
fffonion
reviewed
Jul 15, 2024
kong/pdk/log.lua
Outdated
| @@ -640,7 +641,7 @@ do | |||
|
|
|||
| local function is_valid_value(v, visited) | |||
| local t = type(v) | |||
| if v == nil or t == "number" or t == "string" or t == "boolean" then | |||
| if v == nil or v == cjson_null or t == "number" or t == "string" or t == "boolean" then | |||
There was a problem hiding this comment.
not a blocker for this PR, but we should also exclude FFI null from it
local ffi = require "ffi"
local n = ffi.new("void*")
print(tostring(n))
print(n == nil)
local cjson = require "cjson"
print(cjson.encode(n))outputs
cdata<void *>: NULL
true
ERROR: /tmp/a.lua:9: Cannot serialise cdata: type not supported
|
Successfully created cherry-pick PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As titled, this PR is to fix the bug reported by FTI-6096
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #FTI-6096