Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): introduce lua-resty-simdjson #13421

Merged
merged 41 commits into from
Jul 30, 2024
Merged

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jul 24, 2024

Summary

lua-resty-simdjson has released the first version 1.0.0.

KAG-3647

Summary:

  • a new conf option cluster_cjson to switch between cjson and simdjson
  • unit test for cjson compatibility

simdjson requires gcc 7.4+, it may not be compiled successfully on some Linux releases (aws-liunx-2).

Checklist

Issue reference

Fix #[issue number]

@github-actions github-actions bot added build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jul 24, 2024
@chronolaw chronolaw marked this pull request as ready for review July 24, 2024 05:45
@chronolaw chronolaw marked this pull request as draft July 24, 2024 05:46
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 24, 2024
@chronolaw chronolaw marked this pull request as ready for review July 25, 2024 09:14
@chronolaw chronolaw added this to the 3.8.0 milestone Jul 25, 2024
@ADD-SP ADD-SP merged commit 3a1eeed into master Jul 30, 2024
26 checks passed
@ADD-SP ADD-SP deleted the feat/integrate_simdjson branch July 30, 2024 09:51
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13421-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13421-to-master-to-upstream
git checkout -b cherry-pick-13421-to-master-to-upstream
ancref=$(git merge-base 4c772c6bf83dead3255d18e4d03b32d71aea64f7 157a369854304ef17a27aaceccd3d740012822a0)
git cherry-pick -x $ancref..157a369854304ef17a27aaceccd3d740012822a0

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jul 30, 2024
@AndyZhang0707 AndyZhang0707 removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Aug 1, 2024
ADD-SP pushed a commit that referenced this pull request Aug 1, 2024
ADD-SP pushed a commit that referenced this pull request Aug 1, 2024
…son` (#13441)

In #13421, we introduced lua-resty-simdjson, but the behavior of encoding has some differences with cjson, this PR disabled simdjson encoding temporarily.

KAG-5061

Related PR: Kong/lua-resty-simdjson#38
oowl pushed a commit that referenced this pull request Aug 15, 2024
Summary:
* a new conf option `cluster_cjson` to switch between cjson and simdjson
* unit test for cjson compatibility

simdjson requires gcc 7.4+, it may not be compiled successfully on some Linux releases (aws-liunx-2).

lua-resty-simdjson has released the first version [`1.0.0`](https://github.com/Kong/lua-resty-simdjson/releases/tag/1.0.0).

KAG-3647

---------

Co-authored-by: Wangchong Zhou <wangchong@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed core/clustering core/configuration core/templates size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants