-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugins): ai proxy cloud identity transformers #13487
Conversation
f766f03
to
908ad65
Compare
@fffonion @liverpool8056 I done all the comments. I think many is just that I haven't commented it so well. |
3456ca2
to
727ed56
Compare
@tysoekong It looks like this PR includes parts of https://github.com/Kong/kong-ee/pull/9930/files plus other changes. Could you rework commits in such a way that it closely matches https://github.com/Kong/kong-ee/pull/9930/files (including changelog) and any addition is in its own separate commit? As it's right now, we would have to squash and merge, which would result in unrelated commits being squashed together |
@gszr Again this one is deliberate! It is because there are EE-only features in this plugin, that are only adjusted in https://github.com/Kong/kong-ee/pull/9930/files It's all in the plan. I will rebase ee 9930 when this gets picked. |
07001ef
to
d4ee8ca
Compare
@tysoekong please squash last commit onto the one above it so we can rebase and merge. |
d4ee8ca
to
6324708
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments; otherwise LGTM!
6324708
to
ce673be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13487-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13487-to-master-to-upstream
git checkout -b cherry-pick-13487-to-master-to-upstream
ancref=$(git merge-base 64a0dd1c5c22f8be266742247f6e30aabd6c08ee ce673be082229d185cd12e727160f131653a6115)
git cherry-pick -x $ancref..ce673be082229d185cd12e727160f131653a6115 |
Summary
ai-request-transformer
andai-response-transformer
plugins.Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
AG-94