fix(admin): reject AdminAPI call with empty tags #13723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/admin-api
cherry-pick kong-ee
nowNick
force-pushed
the
fix/fix-for-tags-null
branch
2 times, most recently
from
26a3788 to
813fd53
Compare
nowNick
changed the title
team-gateway-bot
added
the
author/community
hutchic
approved these changes
Oct 16, 2024
brentos
reviewed
Oct 29, 2024
brentos
reviewed
Oct 29, 2024
2 tasks
nowNick
force-pushed
the
fix/fix-for-tags-null
branch
from
813fd53 to
3818583
Compare
brentos
reviewed
Oct 29, 2024
brentos
reviewed
Oct 29, 2024
|
Just a couple minor comments, otherwise LGTM |
locao
approved these changes
Oct 30, 2024
nowNick
force-pushed
the
fix/fix-for-tags-null
branch
2 times, most recently
from
4c7f8b0 to
3b5af35
Compare
PR Review fixes - remove typo emtpy -> empty
PR Review fixes - improve error message: remove info about empty string
brentos
approved these changes
Oct 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
(cherry picked from commit d1069e6)
3 tasks
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13723-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13723-to-master-to-upstream
git checkout -b cherry-pick-13723-to-master-to-upstream
ancref=$(git merge-base 94c7a9ff549f976888948788241da1b221f17ffa 3b5af359cda51f1f09d72a674cfa38dc3349b554)
git cherry-pick -x $ancref..3b5af359cda51f1f09d72a674cfa38dc3349b554 |
|
Successfully created backport PR for |
github-actions
bot
added
the
incomplete-cherry-pick
locao
pushed a commit
that referenced
this pull request
Oct 30, 2024
(cherry picked from commit d1069e6)
kevwilliams
pushed a commit
that referenced
this pull request
Oct 30, 2024
(cherry picked from commit d1069e6)
locao
removed
the
incomplete-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When querying entities that have tags assigned a user can send a request with
tagsparameter. Previously sendingtags=(empty parameter) resulted in 500 error. This commit changes that so that it returns 400 error as empty explicit tags are not allowed.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-5496
Fix #13591