fix(schema): run check on invalid field #13923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/db
schema-change-noteworthy
cherry-pick kong-ee
This fixes a nil reference if a checker referred to an inexistent field. ``` ./kong/db/schema/init.lua:1267: attempt to index a nil value stack traceback: ./kong/db/schema/init.lua: in function 'run_entity_check' ./kong/db/schema/init.lua:1384: in function 'run_checks' ./kong/db/schema/init.lua:1400: in function 'run_entity_checks' ./kong/db/schema/init.lua:2101: in function 'validate' ./kong/db/schema/init.lua:957: in function 'validate_field' ./kong/db/schema/init.lua:1187: in function 'validate_fields' ./kong/db/schema/init.lua:2091: in function 'validate_insert' ./kong/db/dao/init.lua:470: in function 'check_insert' ./kong/db/dao/init.lua:1155: in function 'insert_entity' ./kong/api/endpoints.lua:409: in function 'fn' ./kong/api/api_helpers.lua:329: in function <./kong/api/api_helpers.lua:307> ```
gszr
force-pushed
the
fix/schema-nil-error
branch
from
c253a77 to
0f932bb
Compare
windmgc
approved these changes
Nov 26, 2024
bungle
approved these changes
Nov 28, 2024
|
Successfully created cherry-pick PR for |
lhanjian
pushed a commit
that referenced
this pull request
Dec 23, 2024
This fixes a nil reference if a checker referred to an inexistent field. ``` ./kong/db/schema/init.lua:1267: attempt to index a nil value stack traceback: ./kong/db/schema/init.lua: in function 'run_entity_check' ./kong/db/schema/init.lua:1384: in function 'run_checks' ./kong/db/schema/init.lua:1400: in function 'run_entity_checks' ./kong/db/schema/init.lua:2101: in function 'validate' ./kong/db/schema/init.lua:957: in function 'validate_field' ./kong/db/schema/init.lua:1187: in function 'validate_fields' ./kong/db/schema/init.lua:2091: in function 'validate_insert' ./kong/db/dao/init.lua:470: in function 'check_insert' ./kong/db/dao/init.lua:1155: in function 'insert_entity' ./kong/api/endpoints.lua:409: in function 'fn' ./kong/api/api_helpers.lua:329: in function <./kong/api/api_helpers.lua:307> ``` (cherry picked from commit a13ed4a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a nil reference if a checker referred to an inexistent field.