Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin] Allow usage of the X-Forwarded-For header in the ip-restriction plugin #1995

Closed
Tieske opened this issue Jan 17, 2017 · 5 comments
Closed
Assignees
Labels
good first issue Issues that beginners/volunteers can easily help with.

Comments

@Tieske
Copy link
Member

Tieske commented Jan 17, 2017

When behind a proxy the ip-restriction plugin will act upon the ip address of the proxy, instead of the original client, passed in the X-Forwarded-For header.

Requires an option to be added to the schema to (dis)allow this.

@Tieske Tieske added the good first issue Issues that beginners/volunteers can easily help with. label Jan 17, 2017
@jammm
Copy link

jammm commented Jan 24, 2017

It would be useful if this can be done for the rate limiting plugin as well, in case it falls back to IP as the identifier for rate limiting.

@subnetmarco
Copy link
Member

subnetmarco commented Jan 26, 2017

@Tieske I have tried to replicate, unsuccessfully. Can you take a look at the test? #2019

We are using the ngx_http_realip_module module under the hood to transparently handle this.

@Tieske Tieske self-assigned this Jan 26, 2017
@bungle
Copy link
Member

bungle commented Mar 27, 2017

I'm pretty sure this is handled with #2236 / #2202.

@bungle
Copy link
Member

bungle commented Apr 15, 2017

@Tieske is this relevant anymore as the we have merged the above?

@Tieske
Copy link
Member Author

Tieske commented Apr 24, 2017

let's close this.

@Tieske Tieske closed this as completed Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that beginners/volunteers can easily help with.
Projects
None yet
Development

No branches or pull requests

4 participants