Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose HTTP URL query parameters in trace span tags #8117

Closed
seh opened this issue Oct 19, 2021 · 1 comment
Closed

Expose HTTP URL query parameters in trace span tags #8117

seh opened this issue Oct 19, 2021 · 1 comment

Comments

@seh
Copy link

seh commented Oct 19, 2021

At present, there's no way to configure the Zipkin plugin to include any details about an HTTP URL's query parameters in the exported trace spans. I see that the kong.request Lua module exposes various ways to read this information in a request handler. Could we consider emulating how we handled the static_tags configuration parameter, such that users instantiating this plugin could specify which query parameters by name that they'd like to include in the published trace spans, perhaps with optional default values to include if the query parameter is absent?

We could also include the entire query string as a span tag, though that would be less useful in subsequent queries.

@gszr gszr transferred this issue from Kong/kong-plugin-zipkin Nov 30, 2021
@mayocream
Copy link
Contributor

This PR includes HTTP path in span name. #8150
I think it make sense to include the HTTP path in any sub-span.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants