Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Add kong.route_name and kong.service_name tags to spans #8125

Closed
vito-laurenza-zocdoc opened this issue Jul 2, 2020 · 5 comments
Closed

Feature Request: Add kong.route_name and kong.service_name tags to spans #8125

vito-laurenza-zocdoc opened this issue Jul 2, 2020 · 5 comments
Labels
plugins/zipkin task/feature Requests for new features in Kong

Comments

@vito-laurenza-zocdoc
Copy link

vito-laurenza-zocdoc commented Jul 2, 2020 •
edited by StarlightIbuki
Loading

Currently we tag spans with kong.route = route.id and kong.service = service.id. In a db-less config, the ID isn't that helpful, but the name of the route and/or the service are.

Tasks
Preview Give feedback
No tasks being tracked yet.
kikito referenced this issue in Kong/kong-plugin-zipkin May 24, 2021
@kikito
feat(handler) service.name and route.name tags
a80fbec 
Fixes #92
kikito referenced this issue in Kong/kong-plugin-zipkin May 24, 2021
@kikito
feat(handler) service.name and route.name tags
6a9483d 
Fixes #92
@gszr gszr transferred this issue from Kong/kong-plugin-zipkin Nov 30, 2021
@gszr gszr added plugins/zipkin task/feature Requests for new features in Kong labels Nov 30, 2021
@hbagdi
Copy link
Member

hbagdi commented Apr 5, 2023

FYI @samugi @StarlightIbuki since we are doing work in this area right now.

@StarlightIbuki StarlightIbuki mentioned this issue Jun 13, 2023
Merged
3 tasks
@kikito
Copy link
Member

kikito commented Aug 1, 2023

@vito-laurenza-zocdoc do you think you can open a pull request for this? You can then ask @samugi for a review

@StarlightIbuki
Copy link
Contributor

StarlightIbuki commented Aug 1, 2023 •
edited
Loading

@kikito I think we have already done? https://github.com/Kong/kong-ee/blob/46acc72912f3c48bdf9f515ed4ac68b265dd4561/kong/plugins/zipkin/handler.lua#L75
Or we should also do this for other tracing systems?

@StarlightIbuki
Copy link
Contributor

StarlightIbuki commented Oct 18, 2023 •
edited
Loading

Internal ticket KAG-2805

@StarlightIbuki
Copy link
Contributor

This issue seems resolved. Please reopen if it's not or if you have other concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugins/zipkin task/feature Requests for new features in Kong
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kikito @gszr @hbagdi @vito-laurenza-zocdoc @StarlightIbuki