Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kpop): duplicate popover elements when transitioning #2239

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Jun 17, 2024

Summary

This PR fixes an issue where two popover elements are present until the transition animation ends.

image

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Tests coverage: test coverage was added for new features and bug fixes
  • Docs: includes a technically accurate README

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 5ea535f
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/66700d0e7badcb0008e06748
😎 Deploy Preview https://deploy-preview-2239--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 5ea535f
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/66700d0ee449af0008cc8cb7
😎 Deploy Preview https://deploy-preview-2239--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Leopoldthecoder Leopoldthecoder force-pushed the fix/duplicate-popover branch 4 times, most recently from 8460448 to 2539f79 Compare June 17, 2024 08:53
@Leopoldthecoder Leopoldthecoder changed the title Fix/duplicate popover fix(kpop): duplicate popover elements when transitioning Jun 17, 2024
@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review June 17, 2024 09:01
@Leopoldthecoder Leopoldthecoder requested a review from a team as a code owner June 17, 2024 09:01
@Leopoldthecoder Leopoldthecoder enabled auto-merge (squash) June 17, 2024 10:01
@Leopoldthecoder Leopoldthecoder merged commit b582c63 into alpha Jun 17, 2024
9 checks passed
@Leopoldthecoder Leopoldthecoder deleted the fix/duplicate-popover branch June 17, 2024 14:15
kongponents-bot pushed a commit that referenced this pull request Jun 17, 2024
# [9.0.0-alpha.178](v9.0.0-alpha.177...v9.0.0-alpha.178) (2024-06-17)

### Bug Fixes

* **kpop:** duplicate popover elements when transitioning ([#2239](#2239)) ([b582c63](b582c63))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0-alpha.178 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants