Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kpagination): detect and fix overflow [KHCP-10930] #2277

Merged
merged 18 commits into from
Jul 16, 2024
Merged

fix(kpagination): detect and fix overflow [KHCP-10930] #2277

merged 18 commits into from
Jul 16, 2024

Conversation

portikM
Copy link
Member

@portikM portikM commented Jul 12, 2024 •
edited
Loading

Summary

Addresses: https://konghq.atlassian.net/browse/KHCP-10930

Changes:

  • KPaginatiion to automatically detect horizontal overflow and adjust number of displayed pagination items until overflow is fixed
  • Styling to stack on mobile (screenshot)

Screenshot 2024-07-12 at 11 52 09 AM

@portikM portikM self-assigned this Jul 12, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 12, 2024 •
edited
Loading

✅ Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit dfad24d
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/6696780394df0200080a6aa2
😎 Deploy Preview https://deploy-preview-2277--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jul 12, 2024 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit dfad24d
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/669678030c6f930008952f23
😎 Deploy Preview https://deploy-preview-2277--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

adamdehaven
adamdehaven requested changes Jul 12, 2024
View reviewed changes
src/components/KPagination/KPagination.vue Show resolved Hide resolved
docs/components/table.md Show resolved Hide resolved
src/components/KPagination/KPagination.vue Outdated Show resolved Hide resolved
src/components/KPagination/KPagination.vue Outdated Show resolved Hide resolved
src/components/KPagination/KPagination.vue Show resolved Hide resolved
src/components/KPagination/KPagination.vue Show resolved Hide resolved
portikM
portikM commented Jul 15, 2024
View reviewed changes
docs/guide/usage.md Outdated Show resolved Hide resolved
adamdehaven
adamdehaven reviewed Jul 15, 2024
View reviewed changes
docs/guide/usage.md Outdated Show resolved Hide resolved
src/components/KPagination/KPagination.vue Outdated Show resolved Hide resolved
adamdehaven
adamdehaven approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@portikM portikM merged commit 13dd7ad into main Jul 16, 2024
9 checks passed
@portikM portikM deleted the fix/khcp-10930-kpagination-smart-width branch July 16, 2024 13:45
kongponents-bot pushed a commit that referenced this pull request Jul 16, 2024
@semantic-release-bot
chore(release): 9.0.13 [skip ci]
8ee2588 
## [9.0.13](v9.0.12...v9.0.13) (2024-07-16)

### Bug Fixes

* **kpagination:** detect and fix overflow [KHCP-10930] ([#2277](#2277)) ([13dd7ad](13dd7ad))
* **kselect:** blur input on click ([#2282](#2282)) ([cf92ae7](cf92ae7))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdehaven adamdehaven adamdehaven approved these changes

@kongponents-bot kongponents-bot Awaiting requested review from kongponents-bot kongponents-bot is a code owner

@jillztom jillztom Awaiting requested review from jillztom jillztom is a code owner

@kaiarrowood kaiarrowood Awaiting requested review from kaiarrowood kaiarrowood is a code owner

Assignees

@portikM portikM

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portikM @kongponents-bot @adamdehaven