Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kpop): bind aria-controls to trigger [KHCP-12832] #2326

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

portikM
Copy link
Member

@portikM portikM commented Aug 6, 2024

Summary

Add aria-label to dropdown trigger button

@portikM portikM self-assigned this Aug 6, 2024
@portikM portikM requested a review from a team as a code owner August 6, 2024 19:08
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 8495712
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/66b2840995cb7b00083247bb
😎 Deploy Preview https://deploy-preview-2326--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 8495712
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/66b284095a97070008a5b89c
😎 Deploy Preview https://deploy-preview-2326--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM enabled auto-merge (squash) August 6, 2024 19:23
@portikM portikM changed the title fix(kdropdown): trigger element aria-label [KHCP-12832] fix(kpop): bind aria-controls to trigger [KHCP-12832] Aug 6, 2024
@portikM portikM merged commit 365abb7 into main Aug 7, 2024
9 checks passed
@portikM portikM deleted the fix/khcp-12832-a11y-fixes branch August 7, 2024 17:00
kongponents-bot pushed a commit that referenced this pull request Aug 7, 2024
## [9.1.8](v9.1.7...v9.1.8) (2024-08-07)

### Bug Fixes

* **kdropdown:** trigger element aria-label [KHCP-12832] ([#2326](#2326)) ([365abb7](365abb7))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.1.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants