-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ktableview): add component [KHCP-9499] #2338
Conversation
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple other thoughts:
- might be nice to be able to provide a non-generated
data-testid
andid
for each row (optional) - An option to truncate cell content if over the width (if this isn’t already included)
- Sticky table headers?
That can be done using
That's already supported by default in both components.
Good call, added |
Ok then that is sufficient. |
Initial pass looks good to me 🚀 |
I believe @DariaYeremina is going to review as well. Before merging here, let's pull the preview package into the new Portal project and see if this new component can easily be swapped in for the Credentials table and satisfies our basic use-case |
I reviewed it and it can be easely adapted to the Credentials table |
/> | ||
``` | ||
|
||
### Cell Events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When cell clicks are enabled in the table, should the cursor be a pointer
on hover for cells with click events? Unsure how complex that CSS would be, but nice if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's actually easy to add, done
Co-authored-by: Adam DeHaven <2229946+adamdehaven@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
# [9.4.0](v9.3.3...v9.4.0) (2024-08-26) ### Features * **ktableview:** add component [KHCP-9499] ([#2338](#2338)) ([5b1ae1b](5b1ae1b))
🎉 This PR is included in version 9.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Jira: https://konghq.atlassian.net/browse/KHCP-9499
Adds KTableView component