Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kpop): always remove click listeners #810

Merged
merged 1 commit into from
Sep 26, 2022
Merged

fix(kpop): always remove click listeners #810

merged 1 commit into from
Sep 26, 2022

Conversation

adamdehaven
Copy link
Member

Summary

Port of #809

PR Checklist

  • Does not introduce dependencies
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test packages/
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@adamdehaven adamdehaven self-assigned this Sep 26, 2022
@netlify
Copy link

netlify bot commented Sep 26, 2022

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 483b94d
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/63320fab6c383a0008cfe7d6
😎 Deploy Preview https://deploy-preview-810--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@adamdehaven adamdehaven merged commit 57a8ba1 into beta Sep 26, 2022
@adamdehaven adamdehaven deleted the fix/kpop-remove-event-listeners branch September 26, 2022 20:57
kongponents-bot pushed a commit that referenced this pull request Sep 26, 2022
@semantic-release-bot
chore(release): 8.0.0-beta.21 [skip ci]
c4e9cfa 
# [8.0.0-beta.21](v8.0.0-beta.20...v8.0.0-beta.21) (2022-09-26)

### Bug Fixes

* **kpop:** always remove click listeners ([#810](#810)) ([57a8ba1](57a8ba1))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 8.0.0-beta.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiarrowood kaiarrowood Awaiting requested review from kaiarrowood

@aanchalm01 aanchalm01 Awaiting requested review from aanchalm01

@jillztom jillztom Awaiting requested review from jillztom

Assignees

@adamdehaven adamdehaven

Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamdehaven @kongponents-bot