Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook integration/e2e tests don't run on GKE (disabled on all but kind) #1613

Open
1 task
shaneutt opened this issue Jul 30, 2021 · 1 comment
Open
1 task

Comments

@shaneutt
Copy link
Contributor

shaneutt commented Jul 30, 2021

Current Behavior

When we originally wrote the webhook integration and e2e tests a hack was used to make them work in the kind environment. These tests do not work against other cluster implementations that are now provided by our testing framework, such as GKE due to these hacks.

Expected Behavior

The webhook integration and e2e tests should be able to run on any backend Cluster type that KTF supports.

Steps To Reproduce

1. create a GKE cluster in KTF
2. run the integration tests with the GKE cluster
3. run the e2e tests with the GKE cluster

Kong Ingress Controller version

v2.0.0-alpha.2

Kubernetes version

v1.20.5

Anything else?

  • remove the t.Skip() that was put in place in the tests when the cluster.Type() != "kind"
@shaneutt shaneutt added the bug Something isn't working label Jul 30, 2021
@mflendrich mflendrich removed their assignment Sep 1, 2021
@mflendrich mflendrich added area/debt and removed bug Something isn't working labels Nov 2, 2021
@mflendrich mflendrich changed the title Webhook integration tests fail outside kind Webhook integration tests disabled on GKE Nov 2, 2021
@mflendrich mflendrich changed the title Webhook integration tests disabled on GKE Webhook integration tests don't run on GKE (disabled on all but kind) Nov 2, 2021
@mflendrich
Copy link
Contributor

Our current tests running on kind cover the functional area, so this is a debt item with little current practical implications, but setting a bad quality precedent.

@mflendrich mflendrich added the help wanted Extra attention is needed label Nov 2, 2021
@czeslavo czeslavo changed the title Webhook integration tests don't run on GKE (disabled on all but kind) Webhook integration/e2e tests don't run on GKE (disabled on all but kind) Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants