fix: knative ingress tests #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #1646 +/- ##
==========================================
+ Coverage 62.19% 62.35% +0.15%
==========================================
Files 83 83
Lines 7283 7283
==========================================
+ Hits 4530 4541 +11
+ Misses 2421 2409 -12
- Partials 332 333 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rainest
approved these changes
Aug 3, 2021
This was causing a conflict under some conditions as the CRDs could be loaded multiple times simoltaneously.
This patch fixes several issues with the knative tests and adjusts them for the inclusion of the knative addon from the test framework: - removed deployment logic (the addon does this now) - added resource cleanup for knative.Services created - general code cleanup and logging improvements The result is that tests are now passing consistently against GKE clusters (particularly older v1.17 and v1.18 clusters) and can be run repeatedly without triggering conflicts.
shaneutt
force-pushed
the
fix-knative-ingress-tests
branch
from
1ae6d8e to
d690d7c
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When releasing
v2.0.0-alpha.3some problems were encountered with the Knative ingress tests, which turned out to be flakes caused by timing issues with deploying Knative components. This PR removes all provisioning of Knative components in favor of leaving that up to the testing environment's Knative addon, fixes some issues, does some refactoring of the tests and ultimately re-enables the tests in release testing CI in support of upcomingv2.xreleases.Which issue this PR fixes
Fixes #1637
Special notes for your reviewer:
Blocked by Kong/kubernetes-testing-framework#77
I have tested this manually with both
v1.17andv1.18GKE clusters locally to to ensure they pass. I made sure to run the tests multiple times in a row to validate cleanup and ensure test idempotency, and did not run into any errors.