Run integration tests with Enterprise version #1900
Conversation
Co-authored-by: Jimin <jimin.hu@konghq.com>
Use go-kong ExistsByName() API for retrieving workspaces. This allows KIC to confirm a workspace's presence with a user that has access to that workspace only. Previously, KIC could only retrieve workspaces with an RBAC user that had access to the default workspace. Co-authored-by: Jimin <jimin.hu@konghq.com>
This reverts commit 1029002.
Remove the image environment variable from the Enterprise tests. This was a holdover from earlier development. The image and tag is now set in KTF via WithProxyEnterpriseEnabled().
Set KONG_LICENSE_DATA from the KONG_ENTERPRISE_LICENSE Github secret. KONG_LICENSE_DATA is the actual variable Kong reads, and what should be set in the test environment. KONG_ENTERPRISE_LICENSE is what we happened to name the repo secret that populates it.
|
E2E failure looks to be the same unrelated issue mentioned in #1914 (comment) Re-requesting review as we should have actually included the change to workspace lookup in 2.0 GA, and will want to release a hotfix with that quickly. I don't care about the secret/actual environment variable name matching much: again, I can't fix it completely, so if you do want to make it match throughout, please feel free to update the repo config and push a commit to change it. |
Co-authored-by: Shane Utt <shaneutt@linux.com>
Co-authored-by: Shane Utt <shaneutt@linux.com>
Simplify test RBAC environment by just always using a static password. The test doesn't need actual security, and the main qualities its password needs is (a) to exist and allow RBAC testing at all and (b) to be obvious to the tester during manual runs, in case test failures require manual inspection of the admin API to clear.
rainest
force-pushed
the
test/enterprise-integration
branch
from
e7306db to
7852b40
Compare
|
Integration failure was due to a leftover empty string placeholder variable in the args. That's now: I still cannot see why that broke on the healthz test, since that's just a raw httpc call, not something that uses the controller/admin API interaction. The broken parameter did break everything else though--running it locally ran into a fatal panic when the controller failed to retrieve Kong configuration--so maybe there was just something bizarre with the CI environment output? |
What this PR does / why we need it:
Revamped version of #1758 reduced down to only test using KTF's Enterprise features and to pass workspace/RBAC configuration in when starting the test controller. It does not attempt to upgrade decK or fix the race conditions we currently encounter with it.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #1279Special notes for your reviewer:
KONG_LICENSE_DATA.PR Readiness Checklist:
Changelog n/a, testing only.