Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust validation of ClientOpts for Kong admin API client #7064

Open
2 of 3 tasks
programmer04 opened this issue Jan 29, 2025 · 0 comments
Open
2 of 3 tasks

Robust validation of ClientOpts for Kong admin API client #7064

programmer04 opened this issue Jan 29, 2025 · 0 comments
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality.

Comments

@programmer04
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Does this enhancement require public documentation?

  • I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement

The PR

reworked client and initially introduced validation to not allow mutually exclusive options to be set, see

1a6f7cc#diff-540e5a66571fe7ea83c6641fb9bc48b485ee07dce80a1f28de9ddccd2bf77d0c

but it breaks the Ingress Chart, which sets paths for certs, and TLSSkipVerify option too (which takes precedence).

Read for more context #7033 (comment)

Proposed Solution

When Ingress Chart compatibility won't be a problem (e.g. moving this to KO), bring back 1a6f7cc#diff-540e5a66571fe7ea83c6641fb9bc48b485ee07dce80a1f28de9ddccd2bf77d0c the change

Additional information

No response

Acceptance Criteria

  • setting mutually exclusive (overlapping) options for TLS is forbidden and reports an error on startup (this is exactly what the aforementioned change had made)
@programmer04 programmer04 added the area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality.
Projects
None yet
Development

No branches or pull requests

1 participant