New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify viper flag unmarshaling #868

Closed

mflendrich opened this issue Sep 22, 2020 · 2 comments

Labels

area/debt stale

Contributor

mflendrich commented Sep 22, 2020

It is possible to remove one layer of logic (and tests) in flag handling by replacing the config.Xxx = viper.GetXxx("xxx") calls (and the ifology for default values) by the unmarshaler in viper.

Context: https://github.com/Kong/kubernetes-ingress-controller/pull/866/files#r492612779

A possible extension of this task would be using cobra to wrap the flags in the context of a cobra.Command instead of defining them globally in main.

The text was updated successfully, but these errors were encountered:

mflendrich added trello area/debt labels

mflendrich changed the title ~~viper/~~ simplify viper flag unmarshaling

mflendrich mentioned this issue

chore(flags) remove deprecated flags #866

Merged

mflendrich removed the trello label

stale bot commented Mar 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the stale label

Contributor Author

mflendrich commented Mar 22, 2021

KIC 2.0 will come with flag handling rebuilt from scratch.

mflendrich closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment