Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(entities-plugins): issues in KM #1009

Merged
merged 10 commits into from
Dec 23, 2023
Merged

fix(entities-plugins): issues in KM #1009

merged 10 commits into from
Dec 23, 2023

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Dec 15, 2023 •
edited
Loading

Summary

  1. PluginEntityForm doesn't need to verify config.cancelRoute and config.backRoute
  2. fixed endpoints for scoped plugins
  3. fixed endpoint for developer plugins
  4. fixed endpoint for developer credentials
  5. docsUrlName is no longer needed
  6. added support for the vault-auth plugin (reference: https://github.com/Kong/kong-admin/pull/3018)
  7. fixed an issue in KM that custom schema for credentials are not respected
  8. fixed some style, e.g. OIDC form and switch input

Resources

@Leopoldthecoder Leopoldthecoder force-pushed the fix/plugin-form branch 3 times, most recently from f0b4367 to 3dfa745 Compare December 21, 2023 08:01
@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review December 21, 2023 08:07
kaiarrowood
kaiarrowood reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, just a nit/question

packages/entities/entities-plugins/src/components/PluginForm.vue Outdated Show resolved Hide resolved
packages/entities/entities-plugins/src/plugins-endpoints.ts Show resolved Hide resolved
sumimakito
sumimakito approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested with KM and looks good to me in general 🚀

@Leopoldthecoder Leopoldthecoder merged commit fc47c0e into main Dec 23, 2023
7 checks passed
@Leopoldthecoder Leopoldthecoder deleted the fix/plugin-form branch December 23, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiarrowood kaiarrowood kaiarrowood left review comments

@sumimakito sumimakito sumimakito approved these changes

@LukeSwierlik LukeSwierlik Awaiting requested review from LukeSwierlik LukeSwierlik is a code owner

@QueaT-kong QueaT-kong Awaiting requested review from QueaT-kong QueaT-kong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leopoldthecoder @sumimakito @kaiarrowood