Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vfg): kongponents usage [khcp-11333] #1322

Merged
merged 13 commits into from
Apr 23, 2024

Conversation

kaiarrowood
Copy link
Contributor

@kaiarrowood kaiarrowood commented Apr 10, 2024

Summary

First drop of VFG refactor.
Part of KHCP-11323.

Preview package with passing plugins e2es:
https://github.com/Kong/konnect-ui-apps/pull/2968

Resources

@kaiarrowood kaiarrowood self-assigned this Apr 10, 2024
@adamdehaven
Copy link
Member

adamdehaven commented Apr 10, 2024

Commenting before I forget - you should absolutely issue a breaking change commit (if you're unsure how to do so, use the pnpm commit command after staging your changes and the CLI will walk you through it).

@sumimakito
Copy link
Member

It also appears that we are not using @kong-ui-public/forms as a plugin and thus not calling the install function in host apps:

install: (app: App): void => {
app.component('VueFormGenerator', VueFormGenerator)
app.directive('attributes', attributesDirective)
},

We would then need to update the app initialization steps in host apps as well as the sandbox:

app.component('VueFormGenerator', VueFormGenerator)

with

import Forms '../src'
app.use(Forms)

in order to apply the directive defined via app.directive.

@kaiarrowood kaiarrowood force-pushed the feat/khcp-11333-vfg-kongponents branch from 25f0796 to cd9fdbe Compare April 12, 2024 21:01
@kaiarrowood kaiarrowood force-pushed the feat/khcp-11333-vfg-kongponents branch from 0beee07 to 6b76112 Compare April 22, 2024 13:54
BREAKING CHANGE: Updated to use `lodash-es` instead of `lodash` and use kongponents for input and
label
@kaiarrowood kaiarrowood marked this pull request as ready for review April 22, 2024 17:51
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Leopoldthecoder Leopoldthecoder merged commit 32b29bc into main Apr 23, 2024
31 checks passed
@Leopoldthecoder Leopoldthecoder deleted the feat/khcp-11333-vfg-kongponents branch April 23, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants