-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vfg): kongponents usage [khcp-11333] #1322
Conversation
Commenting before I forget - you should absolutely issue a breaking change commit (if you're unsure how to do so, use the |
It also appears that we are not using public-ui-components/packages/core/forms/src/index.ts Lines 8 to 11 in 4a9f171
We would then need to update the app initialization steps in host apps as well as the sandbox:
with import Forms '../src'
app.use(Forms) in order to apply the directive defined via |
25f0796
to
cd9fdbe
Compare
0beee07
to
6b76112
Compare
BREAKING CHANGE: Updated to use `lodash-es` instead of `lodash` and use kongponents for input and label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
First drop of VFG refactor.
Part of KHCP-11323.
Preview package with passing plugins e2es:
https://github.com/Kong/konnect-ui-apps/pull/2968
Resources