Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms): use KTextArea in array fields [KM-249] #1459

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix(forms): use KTextArea in array fields [KM-249] #1459

merged 1 commit into from
Jun 20, 2024

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented Jun 19, 2024 •
edited
Loading

Summary

This PR makes the VFG use KTextArea in array fields.

Screenshot 2024-06-19 at 19 16 02

FieldTextArea is not used anymore, but we will clean it in the refactor PR along with other unused fields.

  • Adoption PR linked

KM-249

@sumimakito sumimakito marked this pull request as ready for review June 20, 2024 06:58
Leopoldthecoder
Leopoldthecoder approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nekolab
nekolab approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@nekolab nekolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and LGTM

@sumimakito sumimakito merged commit 0c3d23b into main Jun 20, 2024
8 checks passed
@sumimakito sumimakito deleted the KM-249-func-plugins branch June 20, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leopoldthecoder Leopoldthecoder Leopoldthecoder approved these changes

@nekolab nekolab nekolab approved these changes

@LukeSwierlik LukeSwierlik Awaiting requested review from LukeSwierlik LukeSwierlik is a code owner

@QueaT-kong QueaT-kong Awaiting requested review from QueaT-kong QueaT-kong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumimakito @nekolab @Leopoldthecoder