Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(githubStar): add tooltipText prop to GitHub Star component [KHCP-6183] #154

Merged
merged 6 commits into from
Feb 17, 2023

Conversation

mptap
Copy link
Contributor

@mptap mptap commented Feb 16, 2023

https://konghq.atlassian.net/browse/KHCP-6183

Summary

Adds a new tooltip text prop for the GitHub Star component that accepts a string to display a KTooltip when hovered.
The default text reads, "Star this repository on Github".

Screenshot 2023-02-16 at 3 47 52 PM

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@mptap mptap self-assigned this Feb 16, 2023
@mptap mptap force-pushed the feat/KHCP-6183-tooltip-github-star branch from 58cc82e to 30072bb Compare February 16, 2023 23:49
@mptap mptap marked this pull request as ready for review February 16, 2023 23:49
@mptap mptap requested a review from a team as a code owner February 16, 2023 23:49
@mptap mptap requested a review from a team February 16, 2023 23:49
@mptap mptap marked this pull request as draft February 16, 2023 23:53
@mptap mptap marked this pull request as ready for review February 16, 2023 23:59
@mptap mptap enabled auto-merge (squash) February 17, 2023 00:00
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment on the test

Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - 🎸

@mptap mptap merged commit 8f983f9 into main Feb 17, 2023
@mptap mptap deleted the feat/KHCP-6183-tooltip-github-star branch February 17, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants