-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(entities-*): externalize deps #1579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdehaven
commented
Aug 23, 2024
adamdehaven
commented
Aug 23, 2024
ValeryG
reviewed
Aug 27, 2024
ValeryG
reviewed
Aug 27, 2024
what we probably should also do is to look at every package and change those full overrides of externals to "append to what is in shared" logic? |
adamdehaven
commented
Aug 29, 2024
@@ -19,11 +19,7 @@ const config = mergeConfig(sharedViteConfig, defineConfig({ | |||
}, | |||
rollupOptions: { | |||
external: [ | |||
'@kong-ui-public/entities-shared', | |||
'@kong-ui-public/entities-shared/dist/style.css', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ValeryG @2eha0 we are not externalizing the styles anymore as a consuming application fails to resolve:
FAIL src/stores/tests/sidebar.spec.ts [ src/stores/tests/sidebar.spec.ts ]
TypeError: Unknown file extension ".css" for /Users/val.gorodnichev@konghq.com/Code/Kong/ui/konnect-ui-apps/node_modules/.pnpm/@kong-ui-public+entities-shared@3.7.8-pr.1579.613e3228.0_@kong-ui-public+i18n@2.2.2_typescrip_p6jtyje3fjnz4ykopxijenw6pq/node_modules/@kong-ui-public/entities-shared/dist/style.css
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 'ERR_UNKNOWN_FILE_EXTENSION' }
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯
Test Files 1 failed (1)
* fix: more vite.config cleanups * Update packages/entities/entities-routes/vite.config.ts Co-authored-by: Adam DeHaven <2229946+adamdehaven@users.noreply.github.com> * Update packages/analytics/analytics-geo-map/vite.config.ts Co-authored-by: Adam DeHaven <2229946+adamdehaven@users.noreply.github.com> * Update vite.config.ts * Update vite.config.ts --------- Co-authored-by: Adam DeHaven <2229946+adamdehaven@users.noreply.github.com>
Leopoldthecoder
approved these changes
Sep 4, 2024
sumimakito
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the build configuration of
entities-*
packages to externalize common dependencies.Externalizes:
@kong-ui-public/entities-shared
@kong/icons
Switches the Kongponents external to utilize a Regular Expression
The
.npmrc
changes need to be replicated inkonnect-ui-apps
Before
After
Before
After
Consuming PR in konnect-ui-apps