Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): externalize dependencies and add rollup-plugin-visualizer [KHCP-5862] #22

Merged
merged 5 commits into from
Jan 21, 2023

Conversation

adamdehaven
Copy link
Member

@adamdehaven adamdehaven commented Jan 21, 2023

Summary

Our packages were not properly listing build.rollupOptions.external in the vite.config.ts to prevent certain imports/dependencies from being bundled, meaning the bundle sizes were 1-2 MB (😱).

I have added an entry in the shared config at the root of the repo. Any externals added at the package level will be merged with the root config array.

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@adamdehaven adamdehaven merged commit 091fd7e into main Jan 21, 2023
@adamdehaven adamdehaven deleted the fix/khcp-5862-externalize-packages branch January 21, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant