Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(i18n): add formatUnixTimeStamp and formatIsoDate to i18n [KHCP-7929] #616

Merged
merged 5 commits into from
Jul 19, 2023
Merged

feat(i18n): add formatUnixTimeStamp and formatIsoDate to i18n [KHCP-7929] #616

merged 5 commits into from
Jul 19, 2023

Conversation

mptap
Copy link
Contributor

@mptap mptap commented Jul 18, 2023 •
edited
Loading

Summary

feat(i18n): add formatUnixTimeStamp and formatIsoDate to i18n KHCP-7929
https://konghq.atlassian.net/browse/KHCP-7929

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@mptap mptap self-assigned this Jul 18, 2023
@mptap mptap force-pushed the feat/khcp-7929-human-readable-time-format branch 2 times, most recently from 79147b1 to 379f6b3 Compare July 18, 2023 21:22
@mptap mptap force-pushed the feat/khcp-7929-human-readable-time-format branch from 379f6b3 to e3701a8 Compare July 18, 2023 21:23
@mptap mptap changed the title feat(i18n): add formatDate and formatIsoDate to i18n [KHCP-7929] feat(i18n): add formatUnixTimeStamp and formatIsoDate to i18n [KHCP-7929] Jul 18, 2023
@mptap mptap marked this pull request as ready for review July 18, 2023 22:04
@mptap mptap enabled auto-merge (squash) July 18, 2023 22:05
ValeryG
ValeryG previously requested changes Jul 19, 2023
View reviewed changes
packages/core/i18n/src/i18n.ts Show resolved Hide resolved
adamdehaven
adamdehaven reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit; defer to Val for the rest 😄

packages/core/i18n/README.md Outdated Show resolved Hide resolved
@mptap mptap merged commit 7f97762 into main Jul 19, 2023
9 checks passed
@mptap mptap deleted the feat/khcp-7929-human-readable-time-format branch July 19, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValeryG ValeryG ValeryG approved these changes

@jillztom jillztom Awaiting requested review from jillztom jillztom is a code owner

@adamdehaven adamdehaven Awaiting requested review from adamdehaven adamdehaven is a code owner

Assignees

@mptap mptap

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mptap @adamdehaven @ValeryG