fix(tsconfig): apply @vue/tsconfig
#729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekolab
force-pushed
the
chore/vue-tsconfig
branch
from
fde1022 to
8e2b465
Compare
nekolab
requested review from
a team,
LukeSwierlik,
QueaT-kong,
adamdehaven,
ValeryG and
jillztom
as code owners
adamdehaven
requested changes
Aug 22, 2023
adamdehaven
reviewed
Aug 22, 2023
adamdehaven
requested changes
Aug 22, 2023
adamdehaven
reviewed
Aug 22, 2023
This was referenced Aug 22, 2023
Use an exported `const enum` in vite is forbidden due to the [compiler limitation](https://vitejs.dev/guide/features.html#isolatedmodules). To fix this, some `const enum` exports need to be reshape to `enum`. Besides the `const enum`, we also need to use the Type-Only Imports and Export syntax to avoid potential problems like type-only imports being incorrectly bundled. See https://vitejs.dev/guide/features.html#transpile-only These restrictions are all included in `@vue/tsconfig`, so we applied it to the root `tsconfig.json` to prevent further issues.
nekolab
force-pushed
the
chore/vue-tsconfig
branch
from
8e2b465 to
5940fe0
Compare
nekolab
changed the title
@vue/tsconfig@vue/tsconfig
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an exported
const enumin vite is forbidden due to the compiler limitation. To fix this, someconst enumexports need to be reshape toenum.Besides the
const enum, we also need to use the Type-Only Imports and Export syntax to avoid potential problems like type-only imports being incorrectly bundled. See https://vitejs.dev/guide/features.html#transpile-onlyThese restrictions are all included in
@vue/tsconfig, so we applied it to the roottsconfig.jsonto prevent further issues.Summary
PR Checklist