Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance text consistency and SNI table UI #841

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

nekolab
Copy link
Contributor

@nekolab nekolab commented Oct 17, 2023

Changes:

  • Align vault and plugin delete modal titles by changing "Delete Plugin/Vault" to "Delete a Plugin/Vault", matching other entity modal titles.
  • Correct typo in the SNI name placeholder.
  • Introduce disable-row-click prop to EntityBaseTable for improved control over clickable row UI in the KTable component. The current implementation of KTable doesn't allow us to wrap it in other component while still keeping row clickable UI switchable
  • Deactivate clickable UI for SNI list (no detail page for SNI entity).
  • Prioritize displaying the plugin instance name over the plugin name in the delete modal.

Summary

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@nekolab nekolab requested review from a team as code owners October 17, 2023 07:35
Changes:
* Align vault and plugin delete modal titles by changing "Delete Plugin/Vault"
  to "Delete a Plugin/Vault", matching other entity modal titles.
* Correct typo in the SNI name placeholder.
* Introduce `disable-row-click` prop to `EntityBaseTable` for improved control
  over clickable row UI in the `KTable` component. The current implementation
  of `KTable` doesn't allow us to wrap it in other component while still keeping
  row clickable UI switchable
* Deactivate clickable UI for SNI list (no detail page for SNI entity).
* Prioritize displaying the plugin instance name over the plugin name in the delete modal.
@nekolab nekolab force-pushed the fix/delete-modal-text-and-sni-table-appearance branch from 002e0ec to 0d6b7c5 Compare October 17, 2023 08:05
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nekolab nekolab merged commit 3831ea7 into main Oct 18, 2023
@nekolab nekolab deleted the fix/delete-modal-text-and-sni-table-appearance branch October 18, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants