Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entities-plugins): oidc form fields #965

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

Leopoldthecoder
Copy link
Member

Summary

This PR fixes the following plugin form fields:

  • OIDC:
    • client_jwk
    • session_redis_cluster_nodes
  • SAML:
    • session_redis_cluster_nodes

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Manually tested with both the sandbox and Kong Manager

@Leopoldthecoder Leopoldthecoder merged commit 6cd0176 into main Dec 1, 2023
7 checks passed
@Leopoldthecoder Leopoldthecoder deleted the fix/oidc-plugin branch December 1, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants