Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show token when standing on All accounts mode in case token does not get balance #2352

Closed
Sokol142196 opened this issue Dec 14, 2023 · 3 comments · Fixed by #3497
Closed
Assignees
Milestone

Comments

@Sokol142196
Copy link

Describe the task
Do not show token when standing on All accounts mode in case token does not get balance

For example, I turn on Subspace Gemini 3f (tSSC) but do not get balance
Then, i switch to "All accounts" mode with setting Show zero balance is true and observe list token displayed

Actual: Do not show tSSC (Subspace Gemini 3f) token

  • Note: Specific account mode still showing token

Image

Expect: Show token

@dungnguyen-art
Copy link

I cannot reproduce this error at the moment. @ThaoNguyen998 Please check it.

@dungnguyen-art
Copy link

dungnguyen-art commented May 13, 2024

Problem: For networks that are losing connectivity. In “All account” mode: The example does not display NUUM.
Research: I checked and found that the data returned from the background of BalanceItem in the file (useAccountBalance.ts) has a status of not_support. Therefore, this token is not displayed on the UI.
This is 2 lines code handle it in file useAccountBalance.ts.

const balanceItem = balanceMap[address]?.[tokenSlug];
....
const isTokenNotSupport = !!balanceItem && (balanceItem.state === APIItemState.NOT_SUPPORT);

@haiyenvu23
Copy link

haiyenvu23 commented Sep 4, 2024

Version test : http://14.224.129.242:8900/s/pCmdydtjjJFXXZB
Validation passed in case :

  • Install/Update version
  • Check show token on Home, token details, search token screen
  • Check show token on Specific/All account mode

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants