Skip to content

Commit 5e01d86

Browse files
committed
fixup! Fixed one failing test for #713: convertTo can create a temporary non-nullable column with nulls in it. This is now avoided and the behavior has been simplified/stabilized
1 parent 46e1017 commit 5e01d86

File tree

1 file changed

+1
-1
lines changed
  • core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api

1 file changed

+1
-1
lines changed

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/convertTo.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,8 +276,8 @@ internal fun AnyFrame.convertToImpl(
276276

277277
dsl.fillers.forEach { filler ->
278278
val paths = result.getColumnPaths(UnresolvedColumnsPolicy.Create, filler.columns).toSet()
279-
missingPaths -= paths
280279
val (newPaths, existingPaths) = paths.partition { it in missingPaths }
280+
missingPaths -= paths
281281

282282
// first fill cols that are already in the df
283283
result = result.update { existingPaths.toColumnSet() }.with { filler.expr(this, this) }

0 commit comments

Comments
 (0)