Skip to content

Read function with just skipLines = #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jolanrensen opened this issue Nov 20, 2023 · 2 comments · Fixed by #902
Closed

Read function with just skipLines = #507

Jolanrensen opened this issue Nov 20, 2023 · 2 comments · Fixed by #902
Assignees
Labels
csv CSV / delim related issues enhancement New feature or request
Milestone

Comments

@Jolanrensen
Copy link
Collaborator

image
Currently, the delimiter = in the DataFrame.read() in csv.kt function has no default value. This causes that read function to fail unless you explicitly specify it.

We should either:

  • remove the read overload, as it's called "read" and not "readCsv". Shouldn't this be a generic function?
  • Add ',' as default delimiter, just as in the readCSV() function.
@Jolanrensen Jolanrensen added the invalid This issue/PR doesn't seem right label Nov 20, 2023
@WizCoderr
Copy link

i want to work on this issue please assign this issue to me

@Jolanrensen
Copy link
Collaborator Author

Sure, @WizCoderr, how do you plan to tackle it?

@zaleslaw zaleslaw removed the invalid This issue/PR doesn't seem right label Apr 8, 2024
@zaleslaw zaleslaw added this to the 0.14.0 milestone Apr 23, 2024
@Jolanrensen Jolanrensen added enhancement New feature or request csv CSV / delim related issues labels Aug 20, 2024
@Jolanrensen Jolanrensen mentioned this issue Aug 20, 2024
28 tasks
@zaleslaw zaleslaw modified the milestones: 0.14.0, Backlog Sep 16, 2024
@Jolanrensen Jolanrensen assigned Jolanrensen and unassigned WizCoderr Oct 22, 2024
@Jolanrensen Jolanrensen modified the milestones: Backlog, 0.15.0 Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csv CSV / delim related issues enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants