Skip to content

Commit ab756ea

Browse files
committed
fix: platform filtering in multimodule
1 parent 9f90646 commit ab756ea

File tree

2 files changed

+12
-8
lines changed
  • dokka-subprojects
    • plugin-base/src/main/resources/dokka/ui-kit
    • plugin-base-frontend/src/main/ui-kit/filter-section

2 files changed

+12
-8
lines changed

dokka-subprojects/plugin-base-frontend/src/main/ui-kit/filter-section/index.ts

+11-7
Original file line numberDiff line numberDiff line change
@@ -156,21 +156,25 @@ declare global {
156156
activeFilters: (string | null | undefined)[];
157157
};
158158

159+
function filterSourceset(sourceset: string): void;
160+
161+
function unfilterSourceset(sourceset: string): void;
162+
159163
function refreshFiltering(): void;
160-
function refreshSourcesetsCache(): void;
161164
}
162165

163166
/**
164167
* This syncs platform tags and dropdown options filtering behavior.
165168
*/
166169
function toggleFilterForOption(option: Element): void {
167170
const dataFilter = option.querySelector('.checkbox--input')?.getAttribute('data-filter');
168-
const index = filteringContext.activeFilters.findIndex((item) => item === dataFilter);
169-
if (index === -1) {
170-
filteringContext.activeFilters.push(dataFilter);
171-
} else {
172-
filteringContext.activeFilters.splice(index, 1);
171+
if (dataFilter) {
172+
const index = filteringContext.activeFilters.findIndex((item) => item === dataFilter);
173+
if (index === -1) {
174+
unfilterSourceset(dataFilter);
175+
} else {
176+
filterSourceset(dataFilter);
177+
}
173178
}
174179
refreshFiltering();
175-
refreshSourcesetsCache();
176180
}

dokka-subprojects/plugin-base/src/main/resources/dokka/ui-kit/ui-kit.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)