Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added API for reading and writing of floating point numbers #193

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

shanshin
Copy link
Contributor

@shanshin shanshin commented Aug 1, 2023

Implemented extension functions for reading and writing values with types Float and Double

Resolves #167

@shanshin shanshin requested a review from fzhinkin August 1, 2023 09:45
Implemented extension functions for reading and writing  values with types Float and Double

Resolves #167
@fzhinkin fzhinkin linked an issue Aug 2, 2023 that may be closed by this pull request
@shanshin shanshin requested a review from fzhinkin August 7, 2023 06:18
Copy link
Collaborator

@fzhinkin fzhinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanshin shanshin merged commit 8a0ee2c into develop Aug 7, 2023
@shanshin shanshin deleted the floating-numbers branch August 7, 2023 11:42
@elect86
Copy link

elect86 commented Oct 18, 2023

I'd like this on BufferedSource as well

@fzhinkin
Copy link
Collaborator

@elect86 there's no such entity as BufferedSource in kotlinx-io, Source is already buffered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing API: reading and writing of floating point numbers
3 participants